New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Custom Fields for New Product Editor #45396
Conversation
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 53e53f9
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
c2b4150
to
07e0b67
Compare
packages/js/product-editor/src/components/custom-fields/custom-fields.tsx
Show resolved
Hide resolved
I just realized we added this empty scss here. Can we delete it in this PR? |
done -> 53e53f9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
* Create edit modal * Add update function to the useCustomFields hook * Integrate the EditModal in the CustomFields component * Add edition and validation logic to the custom field EditModal component * Fix text control validation error styles * Focus the name field when its invalid * Fix linter error * Fix edit modal min width and controls width * Add changelog file * Fix text overflow in custom fields table * Remove non needed block style file
Submission Review Guidelines:
Changes proposed in this Pull Request:
Partially closes #44169
Depends on #45360
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
New product editor
is enabled under/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=features
product-custom-fields
is enabled underFeatures
tab from/wp-admin/tools.php?page=woocommerce-admin-test-helper
(WooCommerce Beta Tester plugin) is required/wp-admin/admin.php?page=wc-admin&path=/product/{id}&tab=organization
. Replace the{id}
with the one saved in point 1.Organization
tabCustom fields
section the list of the custom fields added in point 1 should be shownEdit
buttonEdit ...
modal should be shown so the custom field could be editedUpdate
Changelog entry
Significance
Type
Message
Comment