Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Custom Fields for New Product Editor #45396

Merged
merged 11 commits into from Mar 11, 2024
Merged

Edit Custom Fields for New Product Editor #45396

merged 11 commits into from Mar 11, 2024

Conversation

mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Mar 7, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Partially closes #44169
Depends on #45360

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new product from the classic editor, add some custom fields and save its id.
  2. Make sure feature New product editor is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features
  3. Make sure feature product-custom-fields is enabled under Features tab from /wp-admin/tools.php?page=woocommerce-admin-test-helper (WooCommerce Beta Tester plugin) is required
  4. Go to /wp-admin/admin.php?page=wc-admin&path=/product/{id}&tab=organization. Replace the {id} with the one saved in point 1.
  5. You should see the Organization tab
  6. Under the Custom fields section the list of the custom fields added in point 1 should be shown
image
  1. Each row should show an Edit button
  2. When click it a new Edit ... modal should be shown so the custom field could be edited
image
  1. Change the name and value of the custom field and then click Update
  2. The modal should close and the changes should be reflected on the table
  3. The update the product and after refreshing the page the changes should persist.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mdperez86 mdperez86 added focus: new product ux revamped product management experience team: Mothra labels Mar 7, 2024
@mdperez86 mdperez86 requested a review from a team March 7, 2024 16:32
@mdperez86 mdperez86 self-assigned this Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Test Results Summary

Commit SHA: 53e53f9

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests304004703516m 26s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 7, 2024
@github-actions github-actions bot removed the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 11, 2024
@octaedro octaedro requested review from octaedro and removed request for a team March 11, 2024 15:25
@octaedro
Copy link
Contributor

I just realized we added this empty scss here. Can we delete it in this PR?

@mdperez86
Copy link
Contributor Author

I just realized we added this empty scss #45360. Can we delete it in this PR?

done -> 53e53f9

@mdperez86 mdperez86 requested a review from octaedro March 11, 2024 17:29
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mdperez86 mdperez86 merged commit 277fa6b into trunk Mar 11, 2024
31 of 32 checks passed
@mdperez86 mdperez86 deleted the add/44169-edit branch March 11, 2024 18:28
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 11, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 11, 2024
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 12, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* Create edit modal

* Add update function to the useCustomFields hook

* Integrate the EditModal in the CustomFields component

* Add edition and validation logic to the custom field EditModal component

* Fix text control validation error styles

* Focus the name field when its invalid

* Fix linter error

* Fix edit modal min width and controls width

* Add changelog file

* Fix text overflow in custom fields table

* Remove non needed block style file
@nigeljamesstevenson nigeljamesstevenson added the release: highlight Issues that have a high user impact and need to be discussed/paid attention to. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience release: highlight Issues that have a high user impact and need to be discussed/paid attention to. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Fields for New Product Editor
4 participants