Unskip Mini Cart i18n test #45371
Merged
Unskip Mini Cart i18n test #45371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results SummaryCommit SHA: 219bded
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
opr
and removed request for
a team
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
gigitux
approved these changes
Mar 7, 2024
...sts/e2e/tests/cart/cart-checkout-block-translations.shopper.block_theme.side_effects.spec.ts
Outdated
Show resolved
Hide resolved
...ce-blocks/tests/e2e/tests/mini-cart/mini-cart-block.shopper.block_theme.side_effects.spec.ts
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing and pre-approving this PR, @gigitux. I've updated the PR based on your feedback and as all tests are passing, I'm merging it now. |
github-actions
bot
added
the
needs: analysis
Stojdza
added
status: analysis complete
Konamiman
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Unskip Mini Cart i18n test * Install language packs before each i18n-related test suite * Delete translations.sh * Add changelog * Replace deprecated WP-CLI command * Remove obsolete WP-CLI command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #45346.
This PR contains the following changes:
User can see translation in empty Mini-Cart.plugins/woocommerce-blocks/tests/e2e/tests/cart/cart-checkout-block-translations.shopper.block_theme.side_effects.spec.ts.plugins/woocommerce-blocks/tests/e2e/tests/mini-cart/mini-cart-block.shopper.block_theme.side_effects.spec.ts.plugins/woocommerce-blocks/tests/e2e/bin/scripts/parallel/translations.shas language pcks will be installed directly in the previous mentioned files.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment