Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip Mini Cart i18n test #45371

Merged
merged 6 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,19 @@ const test = base.extend< { checkoutPageObject: CheckoutPage } >( {
test.describe( 'Shopper → Translations', () => {
test.beforeAll( async () => {
await cli(
`npm run wp-env run tests-cli -- wp language core activate nl_NL`
`npm run wp-env run tests-cli -- wp language core install nl_NL`
);
await cli(
`npm run wp-env run tests-cli -- wp site switch-language nl_NL`
);
await cli(
`npm run wp-env run tests-cli -- wp language plugin install woocommerce nl_NL`
);
} );

test.afterAll( async () => {
await cli(
`npm run wp-env run tests-cli -- wp language core activate en_US`
`npm run wp-env run tests-cli -- wp site switch-language en_US`
);
} );

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,23 @@ import { REGULAR_PRICED_PRODUCT_NAME } from '../checkout/constants';
test.describe( 'Shopper → Translations', () => {
test.beforeAll( async () => {
await cli(
`npm run wp-env run tests-cli -- wp language core activate nl_NL`
`npm run wp-env run tests-cli -- wp language core install nl_NL`
);
await cli(
`npm run wp-env run tests-cli -- wp site switch-language nl_NL`
);
await cli(
`npm run wp-env run tests-cli -- wp language plugin install woocommerce nl_NL`
);
} );

test.afterAll( async () => {
await cli(
`npm run wp-env run tests-cli -- wp language core activate en_US`
`npm run wp-env run tests-cli -- wp site switch-language en_US`
);
} );

// For more details: https://github.com/woocommerce/woocommerce/issues/45346
// eslint-disable-next-line playwright/no-skipped-test
test.skip( 'User can see translation in empty Mini-Cart', async ( {
test( 'User can see translation in empty Mini-Cart', async ( {
page,
frontendUtils,
miniCartUtils,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: dev

Improve stability of i18n-related e2e tests.