Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS on core] Update the WooCommerce Extensions Themes page to include references to the CYS #45468

Merged

Conversation

nefeline
Copy link
Member

@nefeline nefeline commented Mar 10, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Here a series of changes are being made to the WooCommerce Extensions Themes page to include references to the new CYS flow, including:

  • Add the Design your own button. If the current active theme is TT4, it directs users to the assembler, if not, the theme switch warning modal is displayed to confirm the user wants to proceed to the CYS flow and change their current active theme.

  • Add the Design your own section right after the second row of themes. If the current active theme is TT4, the "Start designing" button directs users to the assembler; if not, the theme switch warning modal is displayed to confirm the user wants to proceed to the CYS flow and change their current active theme. It is also important to note that the position of the banner is dynamically changed on screen resize to ensure it preserves its expected position in the second row of themes independent of the number of columns displayed:

  • Add the line Didn't find a theme you like? Browse the WordPress.org theme directory to discover more. The link sends the user to Appearance -> Themes -> Add new Theme with e-commerce as a search term.

Closes #45418.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure you have the WooCommerce Beta Tester plugin installed and activated
  2. Under Tools > WCA Test Helper > Features, make sure customize-store is enabled
  3. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store
  4. Head over to WooCommerce > Extensions > Themes wp-admin/admin.php?page=wc-admin&tab=themes&path=%2Fextensions
  5. Make sure you can visualize the Design your own button. If the current active theme is TT4, it directs users to the assembler, if not, the theme switch warning modal is displayed to confirm the user wants to proceed to the CYS flow and change their current active theme:
Screenshot 2024-03-12 at 09 20 07 Screenshot 2024-03-12 at 09 21 56 6. Make sure you can visualize the Design your own section right after the second row of themes. If the currently active theme is TT4, the "Start designing" button directs users to the assembler; if not, the theme switch warning modal is displayed to confirm the user wants to proceed to the CYS flow and change their current active theme: Screenshot 2024-03-12 at 09 24 42 Screenshot 2024-03-12 at 09 26 25

It is also important to note that the position of the banner is dynamically changed on screen resize to ensure it preserves its expected position in the second row of themes independent of the number of columns displayed:

Screen.Recording.2024-03-12.at.09.31.54.mov
  1. Make sure you can visualize the line Didn't find a theme you like? Browse the WordPress.org theme directory to discover more. The link sends the user to Appearance -> Themes -> Add new Theme with e-commerce as a search term.
Screenshot 2024-03-12 at 09 27 18

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Update the WooCommerce Extensions Theme page to include references to the Customize Your Store flow.

Comment

Copy link
Contributor

github-actions bot commented Mar 10, 2024

Test Results Summary

Commit SHA: f884719

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests760027503517m 19s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@nefeline nefeline self-assigned this Mar 11, 2024
@nefeline nefeline marked this pull request as ready for review March 12, 2024 08:45
@woocommercebot woocommercebot requested review from a team and imanish003 and removed request for a team March 12, 2024 08:45
@nefeline nefeline added focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Mar 12, 2024
Copy link
Contributor

github-actions bot commented Mar 12, 2024

Hi @albarin, @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@nefeline nefeline added the type: enhancement The issue is a request for an enhancement. label Mar 12, 2024
@nefeline nefeline requested review from albarin and gigitux and removed request for imanish003 March 12, 2024 08:47
@nefeline nefeline changed the title [CYS on core] Update the market place themes screen [CYS on core] Update the WooCommerce Extensions Themes page to include references to the CYS Mar 12, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! All is testing good! 👏

@nefeline nefeline merged commit 4933b86 into trunk Mar 12, 2024
34 checks passed
@nefeline nefeline deleted the 45418-cys-on-core-update-the-market-place-themes-screen branch March 12, 2024 10:03
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 12, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 12, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
…e references to the CYS (#45468)

* Introduce the new 'Design your own' button in the themes screen.

* unify the SCSS margins

* Add double quotes for woocommerce-marketplace__sub-header

* Add the CYS banner to the marketplace.

* Ensure each child in a list should have a unique 'key' prop

* Update the NoAIBanner component to direct users to the CYS flow.

* Add the customizeStoreDesignUrl const

* Ditch navigateOrParent

* Add the 'Browse the WordPress.org theme directory to discover more' link.

* Ensure the warning Modal is displayed whenever the user clicks on the 'Design your own' button and their current active theme is not TT4

* Remove the unnecessary fragment

* Add changefile(s) from automation for the following project(s): woocommerce

* Fix lint.

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on core] Update the WooCommerce Extensions Themes page to include references to the CYS
3 participants