New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling to marketplace to identify sponsored products #45684
Conversation
Hi @andfinally, @corsonr, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 197fafd
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hey @Dan-Q, thanks for the ping. I didn't get a chance to test the branch, but from the screenshot I can see a few things:
|
plugins/woocommerce-admin/client/marketplace/components/product-card/product-card.scss
Outdated
Show resolved
Hide resolved
plugins/woocommerce-admin/client/marketplace/components/product-card/product-card.scss
Outdated
Show resolved
Hide resolved
plugins/woocommerce-admin/client/marketplace/components/product-card/product-card.scss
Outdated
Show resolved
Hide resolved
plugins/woocommerce-admin/client/marketplace/components/product-card/product-card.scss
Outdated
Show resolved
Hide resolved
One last thing, I'm not getting the sponsored card to show even when manipulating the props via the label prop set to |
…t-card/product-card.tsx Co-authored-by: Remi Corson <remicorson@gmail.com>
…t-card/product-card.tsx Co-authored-by: Remi Corson <remicorson@gmail.com>
…t-card/product-card.tsx Co-authored-by: Remi Corson <remicorson@gmail.com>
Co-authored-by: Remi Corson <remicorson@gmail.com>
It's funny: you stare at something long enough, you stop seeing the problems!
Fixed in 3b61fcc.
Fixed in 3121d30.
Huh; I see that too, but I don't think it's new to this PR... investigating. |
This is a regression introduced a week ago; @nefeline is handling. |
Here's me doing so - see if doing this works for you: Screen.Recording.2024-03-19.at.11.36.52.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins/woocommerce-admin/client/marketplace/components/product-card/product-card.scss
Outdated
Show resolved
Hide resolved
…t-card/product-card.scss
plugins/woocommerce-admin/client/marketplace/stylesheets/_variables.scss
Outdated
Show resolved
Hide resolved
Turns out the green blobs aren't part of the design, whoops! Fixed in 0b11add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Dan.
&__sponsored-label { | ||
color: $gray-700; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could maybe have been woocommerce-marketplace__product-card__label
, as we may show labels with a different text at some point. Not a big deal I guess.
Changes proposed in this Pull Request:
Closes WCCOM#19612. Where a product on the Marketplace "Discover" page has the
label: 'promoted'
from the WooCom API, adds the word "Sponsored" to the product card and shows a colored spot alongside/overlapping it. If it also has aprimary_color: ...
set, adds a "stripe" of that primary color to the top of the product card.How to test the changes in this Pull Request:
cd plugins/woocommerce-admin; pnpm watch:build
; visit the site in your local server e.g.cd plugins/woocommerce; pnpm -- wp-env start
wc_addons_featured
transient e.g.cd plugins/woocommerce; pnpm -- wp-env run cli wp transient delete wc_addons_featured
; this transient stores featured product dataproduct
associated with each<ProductCard>
Screenshot
Changelog entry
Significance
Type
Message
Made sponsored product listings in the Extensions marketplace easier to identify.
Comment