New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/lys xstate scaffolding #45548
add/lys xstate scaffolding #45548
Conversation
b560ed7
to
de9f3de
Compare
Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 13f4245
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, testing well! 👍
I just have one feedback. I found it a bit difficult to know whether the file is for the sidebar, main content page, or xstate machine definition from the filenames and paths. It's not a problem now, but I think it would be better if we could tell at a glance. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
de9f3de
to
13f4245
Compare
Thanks for the reviews @adrianduffell and @chihsuan! I'm doing the folder organisation this PR since it's a minor work to do here and a fair bit of work to put a new PR up for. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #45116.
Note that this PR has installed xstate v5 simultaneously alongside xstate v4. There is a postinstall script which correctly symlinks the expected packages.
This arrangement will be required to be in place until we migrate the previous xstate machines over to v5.
How to test the changes in this Pull Request:
Please exclude from Solaris and GlobalStep testing as this is gated behind a feature flag and is part of the Launch Your Store feature which will be tested as a complete feature when the call for testing is released.
Screen.Recording.2024-03-13.at.23.53.23.mov
Note that the browser back button will not work as expected as it has not been implemented and will be implemented in a follow up PR.
The XState inspector will also not work as the currently installed version only works for xstate v4 while this PR uses xstate v5. This will also be addressed in a follow up PR. In the mean time please use the debug output in this PR to assist.
Changelog entry
Significance
Type
Message
Comment