Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch your store: Address status issues and filesystem #45688

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

psealock
Copy link
Contributor

@psealock psealock commented Mar 18, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR addresses some left over bits from #45606.

  • The status chip now only shows on the homescreen
  • The "Customize 'Coming soon' page" link is now working
  • Refactor competing folders /launch-your-store and /launch-store by placing the hub in plugins/woocommerce-admin/client/launch-your-store/hub

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Fire up JN site
  2. Turn on the feature flag Tools > WCA Test Helper > Features > launch-your-store
  3. See the status chip only appear on the homescreen
  4. Click the "Customize 'Coming soon' page" link and see that it goes to the address described in add/lys xstate scaffolding #45548

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Update unreleased feature

@github-actions github-actions bot added package: @woocommerce/navigation issues related to @woocommerce/navigation and removed package: @woocommerce/navigation issues related to @woocommerce/navigation labels Mar 18, 2024
@psealock psealock requested review from a team, ilyasfoo, moon0326 and rjchow March 18, 2024 19:10
Copy link
Contributor

github-actions bot commented Mar 18, 2024

Hi @ilyasfoo, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 18, 2024

Test Results Summary

Commit SHA: df62cd0

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests342001403568m 9s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@psealock psealock closed this Mar 18, 2024
@psealock psealock reopened this Mar 18, 2024
@psealock psealock closed this Mar 19, 2024
@psealock psealock reopened this Mar 19, 2024
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well 🚢

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goes to the address described in https://github.com/woocommerce/woocommerce/pull/45548 probably isn't final but I think we will revisit this.

Otherwise tests well and thanks!

@ilyasfoo ilyasfoo closed this Mar 19, 2024
@ilyasfoo ilyasfoo reopened this Mar 19, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 20, 2024
@ilyasfoo ilyasfoo merged commit 27a473e into trunk Mar 20, 2024
30 checks passed
@ilyasfoo ilyasfoo deleted the fix/lys-status-issues branch March 20, 2024 03:26
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@nigeljamesstevenson nigeljamesstevenson removed the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 20, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants