-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch your store: Address status issues and filesystem #45688
Conversation
Hi @ilyasfoo, @moon0326, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: df62cd0
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
fff1412
to
b410dbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goes to the address described in https://github.com/woocommerce/woocommerce/pull/45548
probably isn't final but I think we will revisit this.
Otherwise tests well and thanks!
Merge remote-tracking branch 'origin/trunk' into fix/lys-status-issues
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR addresses some left over bits from #45606.
/launch-your-store
and/launch-store
by placing the hub inplugins/woocommerce-admin/client/launch-your-store/hub
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment
Update unreleased feature