Do not trigger 'pre_update' logic for HPOS option when value remains unchanged

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

We have some pre_update_option logic attached to the HPOS setting woocommerce_custom_orders_table_enabled (which enables HPOS) but this logic is executed regardless of whether the setting is actually changing value or not.

This can result in a confusing experience when a fatal error due to datastores being out of sync is triggered despite the datastore not being changed.

Closes #45225.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Go to WC > Settings > Advanced > Features and choose any datastore as order datastore. Make sure compatibility mode is disabled.
   If datastores are not in sync, run wp wc cot sync first if you want to change the current datastore.
2. Go to WC > Orders and create an order with any details.
3. Go back to WC > Settings > Advanced > Features and confirm that at least an order is reported as in need of sync and you are not allowed to change datastores.
4. Run the following command and confirm that it doesn't trigger any fatal error:

   wp eval "update_option( 'woocommerce_custom_orders_table_enabled', get_option( 'woocommerce_custom_orders_table_enabled' ) );"
   

   Note: This is triggering a fatal error on trunk, so optionally check that too.
5. Confirm that the following command does trigger a fatal error (which would be an attempt to change datastores with orders out of sync):

   wp eval "update_option( 'woocommerce_custom_orders_table_enabled', wc_bool_to_string( ! wc_string_to_bool( get_option( 'woocommerce_custom_orders_table_enabled' ) ) ) );"
   

6. Run wp wc cot sync to sync orders.
7. Confirm that the command from step 5 no longer throws a fatal error.
8. You should've ended with a different datastore to the one you started with, so go to WC > Settings > Advanced > Features and change again or re-enable compatibility mode as necessary.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @lsinger,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: 01b42e2

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	311	0	0	41	0	352	7m 13s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[lsinger]

Looks good, works well. Great testing instructions!