Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger 'pre_update' logic for HPOS option when value remains unchanged #45604

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Do not trigger 'pre_update' logic for HPOS option when value remains unchanged #45604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfe551b
Add changelog
jorgeatorres Mar 14, 2024
01b42e2
Do not trigger pre_update logic for HPOS setting when not actually
jorgeatorres Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/fix-45225
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Prevent fatal error when updating HPOS setting without changing value.
4 changes: 4 additions & 0 deletions plugins/woocommerce/src/Internal/DataStores/Orders/CustomOrdersTableController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ private function process_pre_update_option( $value, $option, $old_value ) {
return $value;
}

if ( $old_value === $value ) {
return $value;
}

$this->order_cache->flush();
if ( ! $this->data_synchronizer->check_orders_table_exists() ) {
$this->data_synchronizer->create_database_tables();
Expand Down