Handle posts > HPOS redirect more gracefully when backup post is missing

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When HPOS is authoritative, we automatically redirect admin URLs for order posts to the corresponding HPOS one. For example, /wp-admin/post.php?post=123&action=edit gets turned into /wp-admin/admin.php?page=wc-orders&action=edit&id=123.

This works correctly when the order post exists, but was producing a 500 error when not.

This is sort of an edge case as we don't endorse removal of the backup post / placeholder post, but we've seen some users doing that after migrating to HPOS anyways.

This PR adds an additional check so that the redirect succeeds in those cases (as long as the HPOS order exists).

Closes #44177.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Make sure HPOS is configured as datastore in WC > Settings > Advanced > Features and that compatibility mode is disabled.
2. Ensure your site has a few orders. If necessary, create some or use Smooth Generator for a smoother testing experience. Make note of some order IDs.
3. Delete the backup post for one of the orders by running the following command:

   wp db query "DELETE FROM $(wp db prefix)posts WHERE ID = <order_id>"
   

4. Visit https://yoursite.test/wp-admin/post.php?post=<order_id>&action=edit and confirm that you're redirected to the (HPOS) order edit screen.
5. Visit https://yoursite.test/wp-admin/post.php?post=<post_id>&action=edit with a <post_id> that has no corresponding post and confirm that you see an error.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 46727c7

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	0	0	0	363	0	363	0m 0s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @vedanshujain,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[vedanshujain]

left couple of minor comments, lgtm otherwise

[jorgeatorres]

@vedanshujain: Thanks for the review! I've implemented your suggestion and simplified the logic a bit. Please let me know what you think.

[vedanshujain]

nice, LGTM!