Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle posts > HPOS redirect more gracefully when backup post is missing #45605

Merged
merged 4 commits into from Mar 21, 2024
Merged

Handle posts > HPOS redirect more gracefully when backup post is missing #45605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02f62de
Attempt to determine order type from HPOS side too in `PostsRedirecti…
jorgeatorres Mar 14, 2024
664f46a
Add changelog
jorgeatorres Mar 14, 2024
a9af5a5
Simplify redirect logic
jorgeatorres Mar 21, 2024
46727c7
Linter hates short ternaries
jorgeatorres Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/fix-44177
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: minor
Type: fix

Gracefully handle posts to HPOS redirect when backup post no longer exists.
8 changes: 7 additions & 1 deletion plugins/woocommerce/src/Internal/Admin/Orders/PostsRedirectionController.php
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@
namespace Automattic\WooCommerce\Internal\Admin\Orders;

use Automattic\WooCommerce\Internal\DataStores\Orders\CustomOrdersTableController;
use Automattic\WooCommerce\Utilities\OrderUtil;

/**
* When {@see OrdersTableDataStore} is in use, this class takes care of redirecting admins from CPT-based URLs
Expand Down Expand Up @@ -126,11 +127,16 @@ private function maybe_redirect_to_new_order_page(): void {
*/
private function maybe_redirect_to_edit_order_page(): void {
$post_id = absint( $_GET['post'] ?? 0 );
if ( ! $post_id ) {
return;
}

$redirect_from_types = wc_get_order_types( 'admin-menu' );
$redirect_from_types[] = 'shop_order_placehold';

if ( ! $post_id || ! in_array( get_post_type( $post_id ), $redirect_from_types, true ) || ! isset( $_GET['action'] ) ) {
$post_type = get_post_type( $post_id );
$order_type = $post_type ? $post_type : OrderUtil::get_order_type( $post_id );
if ( ! in_array( $order_type, $redirect_from_types, true ) || ! isset( $_GET['action'] ) ) {
return;
}

Expand Down