Create update_template_data util and formatting improvements #46408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
|
Hi @WunderBart, @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
|
Hi @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Aljullu
force-pushed
the
add/update_template_data-util
branch
10 times, most recently
from
91d1c60
to
b47c085
Compare
github-actions
bot
added
the
focus: monorepo infrastructure
Aljullu
force-pushed
the
add/update_template_data-util
branch
from
2121efc
to
b47c085
Compare
github-actions
bot
removed
the
focus: monorepo infrastructure
Aljullu
force-pushed
the
add/update_template_data-util
branch
from
b47c085
to
31839e2
Compare
Aljullu
force-pushed
the
add/update_template_data-util
branch
2 times, most recently
from
cfadf3c
to
40911ba
Compare
Aljullu
force-pushed
the
add/update_template_data-util
branch
from
40911ba
to
2c3a629
Compare
WunderBart
approved these changes
Apr 24, 2024
github-actions
bot
added
the
needs: analysis
alvarothomas
added
status: analysis complete
samueljseay
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Create update_template_data util * Fix comment typo * Formatting * Remove unnecessary use of BlockTemplateUtils * Add changelog file * Create update_template_data util (II)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR includes some improvements from #44778. The reason is that #44778 is blocked by upstream work so it's unlikely to be merged soon, so with this PR we will bring to
trunkwhat's currently "mergeable". 馃檪Specifically, this PR includes these changes:
update_template_datautil to avoid code duplication.BlockTemplateUtils.How to test the changes in this Pull Request:
This PR doesn't include any functionality changes, but some basic smoke testing of block templates is appreciated.
Go to Appearance > Editor > Templates.
Make some edits to some templates. Verify you can save them and they preserve the template name on save. Ie: the top bar should show
Single Productinstead ofsingle-product:Visit the templates in the frontend and verify the edits have been applied successfully.
Changelog entry
Significance
Type
Message
Comment