Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update templates that fallback to the Product Catalog template #44778

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Feb 19, 2024

Changes proposed in this Pull Request:

Closes #42531.
Closes #42532.

Current progress

Templates:

Other challenges:

Other ideas:

  • Filter theme.json data instead of calling BlockTemplateUtils::update_template_data() to update template details.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@Aljullu Aljullu added focus: template Issue related to WooCommerce templates. team: Kirigami & Origami labels Feb 19, 2024
@Aljullu Aljullu self-assigned this Feb 19, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Test Results Summary

Commit SHA: c3d6ea6

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests312506403819m 10s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Aljullu Aljullu force-pushed the update/BlockTemplatesController-refactor branch 2 times, most recently from c8cd69e to 5a464fc Compare February 22, 2024 10:37
@Aljullu Aljullu mentioned this pull request Feb 22, 2024
11 tasks
@Aljullu Aljullu force-pushed the update/BlockTemplatesController-refactor branch from c40b66c to 845e751 Compare February 26, 2024 13:55
Base automatically changed from update/BlockTemplatesController-refactor to trunk February 27, 2024 18:05
@WunderBart WunderBart force-pushed the update/templates-fallback-refactor branch from ef336c7 to 9157e57 Compare February 28, 2024 11:27
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch 3 times, most recently from 8145c9b to e477f7d Compare March 20, 2024 10:59
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch 3 times, most recently from 265707d to 70255cb Compare March 28, 2024 17:36
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch 2 times, most recently from 02adbc3 to cd9e24a Compare April 9, 2024 08:38
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch from 0d8d960 to 91a3e66 Compare April 10, 2024 08:51
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch 2 times, most recently from 7680f50 to c1b7b14 Compare April 11, 2024 13:03
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch 3 times, most recently from f57b1b8 to 4b18bbe Compare April 29, 2024 12:21
@Aljullu Aljullu force-pushed the update/templates-fallback-refactor branch from 4b18bbe to dd93a94 Compare April 29, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: template Issue related to WooCommerce templates. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami
Projects
None yet
1 participant