New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update templates that fallback to the Product Catalog template #44778
Draft
Aljullu
wants to merge
6
commits into
trunk
Choose a base branch
from
update/templates-fallback-refactor
base: trunk
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
Issue related to WooCommerce templates.
team: Kirigami & Origami
labels
Feb 19, 2024
github-actions
bot
added
the
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
label
Feb 19, 2024
Test Results SummaryCommit SHA: c3d6ea6
Please address the following issues prior to merging this pull request: |
Aljullu
force-pushed
the
update/BlockTemplatesController-refactor
branch
2 times, most recently
from
February 22, 2024 10:37
c8cd69e
to
5a464fc
Compare
11 tasks
Aljullu
force-pushed
the
update/BlockTemplatesController-refactor
branch
from
February 26, 2024 13:55
c40b66c
to
845e751
Compare
This was
linked to
issues
Feb 27, 2024
Base automatically changed from
update/BlockTemplatesController-refactor
to
trunk
February 27, 2024 18:05
WunderBart
force-pushed
the
update/templates-fallback-refactor
branch
from
February 28, 2024 11:27
ef336c7
to
9157e57
Compare
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
3 times, most recently
from
March 20, 2024 10:59
8145c9b
to
e477f7d
Compare
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
3 times, most recently
from
March 28, 2024 17:36
265707d
to
70255cb
Compare
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
2 times, most recently
from
April 9, 2024 08:38
02adbc3
to
cd9e24a
Compare
11 tasks
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
from
April 10, 2024 08:51
0d8d960
to
91a3e66
Compare
11 tasks
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
2 times, most recently
from
April 11, 2024 13:03
7680f50
to
c1b7b14
Compare
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
3 times, most recently
from
April 29, 2024 12:21
f57b1b8
to
4b18bbe
Compare
Aljullu
force-pushed
the
update/templates-fallback-refactor
branch
from
April 29, 2024 12:24
4b18bbe
to
dd93a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
focus: template
Issue related to WooCommerce templates.
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
team: Kirigami & Origami
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #42531.
Closes #42532.
Current progress
Templates:
Other challenges:
Other ideas:
theme.json
data instead of callingBlockTemplateUtils::update_template_data()
to update template details.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment