Update the version number of some methods in AbstractTemplateCompatibility #47118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
github-actions
bot
added
the
plugin: woocommerce
woocommercebot
requested review from
a team and
ObliviousHarmony
and removed request for
a team
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
ObliviousHarmony
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks @Aljullu, I also confirmed that there aren't any other instances of @since TBD that we should fix.
Aljullu
force-pushed
the
update/class-property-since-tbd
branch
from
8aff65e
to
58bedcc
Compare
github-actions
bot
added
the
needs: analysis
senadir
pushed a commit
that referenced
this pull request
May 7, 2024
…ility (#47118) * Update the version number of some methods in AbstractTemplateCompatibility * Add changelog file
alvarothomas
added
status: analysis complete
thealexandrelara
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ility (#47118) * Update the version number of some methods in AbstractTemplateCompatibility * Add changelog file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Small PR replacing two
@since TBDwith the correct WooCommerce version.For reference, those methods were introduced in woocommerce/woocommerce-blocks#8442, which was merged into WC Blocks 9.8.0, which was released with WC core 7.6.0.
Closes #46874.
How to test the changes in this Pull Request:
(No need to test during the release)
Changelog entry
Significance
Type
Message
Comment