Blocks E2E: Remove the DB snapshot on env reset #47416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
force-pushed
the
fix/remove-e2e-db-snapshot-on-env-reset
branch
from
3d7f0e8
to
a3f5922
Compare
|
Hi @gigitux, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
github-actions
bot
added
the
plugin: woocommerce
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
status: analysis complete
thealexandrelara
pushed a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After merging #46409, I realized that the env reset (
pnpm env:reset) does not remove the DB snapshot, which might cause env conflicts when rerunning multiple times locally. This PR fixes that.How to test
Ensure the DB snapshot is removed after calling
pnpm env:restart. You'll need to run some tests first so that the snapshot is created.