-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the term attribute sort order for the "Filter by attribute" block #47616
Conversation
a06e1be
to
a3633ff
Compare
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
…mmerce-blocks, woocommerce
Hi @samueljseay, @roykho, @imanish003, @kmanijak, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! Nice! 🚀
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR uses the attribute
Default sort order
to sort the attribute terms in theFilter by attribute
block.Closes #42417
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp-admin/edit.php?post_type=product&page=product_attributes
.Configure terms
.1
,8
, and10
.Products
and assign products to the 3 terms you just created.Product Catalog
templates (wp-admin/site-editor.php?postType=wp_template&postId=woocommerce%2Fwoocommerce%2F%2Farchive-product
).Filter by attribute
block, configure it with the attribute you created in step 2, and save.shop
page on the front-end.1
,10
,8
.Edit
.Default sort order
toName (numeric)
, and save.1
,8
,10
.Changelog entry
Significance
Type
Message
Use the term attribute sort order for displaying the "Filter by attribute" terms.
Comment