Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run add_archive_product_to_eligible_for_fallback_templates for block themes only #48385

Closed
wants to merge 2 commits into from

Conversation

WunderBart
Copy link
Contributor

@WunderBart WunderBart commented Jun 11, 2024

What?

Closes #46461

Ensure the add_archive_product_to_eligible_for_fallback_templates hook runs for block themes only.

How to test

Ensure the hook does not leak into classic themes:

  • Activate a block theme (e.g. TT4),
  • Add die() inside the add_archive_product_to_eligible_for_fallback_templates hook,
  • Go to a specific category or tag page, e.g. /product-category/clothing/,
  • Ensure the page dies,
  • Activate a classic theme (e.g. Storefront),
  • Go to the same page as above,
  • Ensure the page does not die.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@WunderBart
Copy link
Contributor Author

WunderBart commented Jun 11, 2024

Warning

Might be superseded by #48382

@WunderBart
Copy link
Contributor Author

Closing because of #48385 (comment)

@WunderBart WunderBart closed this Jun 21, 2024
@WunderBart WunderBart deleted the fix/btc-classic-theme-leak branch August 12, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
1 participant