Allow blocks with parents in the woocommerce namespace to be rendered as inner blocks

[opr]

Changes proposed in this Pull Request:

• Cache the list of registered block types with at least one parent block in the woocommerce namespace. Do this on init.
• When checking blocks that can have data-block-name added, consider if their parent is in the woocommerce namespace (cached above)

Closes #46264

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Register a custom block, in this example we'll be using the @woocommerce/extend-cart-checkout-block test-block package.
2. Go to wp-content/plugins and run npx @wordpress/create-block -t @woocommerce/extend-cart-checkout-block test-block.
3. Edit the block's "lock" attribute (go to src/js/checkout-newsletter-subscription/block.json) so it is:

	"lock": {
			"type": "object",
			"default": {
				"remove": false,
				"move": true
			}
		},

4. Make sure the block is rebuilt after changing this (use npm run start)
5. Go to the Checkout block in the editor, and go to the contact information block.
6. Add a new block, and select the Newsletter Subscription! block.
7. Add another new block and select the core Image block. Add an image to it.
8. Save the page.
9. Go to the front-end, add an item to your cart and visit the Checkout block.
10. Ensure you see the newsletter subscription block and the image block.

11. Go back to the editor and delete the newsletter subscription block. Save the page.
12. Reload the Checkout block in the editor and ensure the newsletter subscription block is not there.
13. Reload the Checkout block on the front-end and ensure the newsletter subscription block is not there.
14. Go back to the block.json settings and set the lock.remove property to true.
15. Save and build, then go to the Checkout block on the front end.
16. Ensure the newsletter subscription block is visible again.

Changelog entry

• Automatically create a changelog entry from the details below.

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Size Change: 0 B

Total Size: 2.49 MB

_{compressed-size-action}

[github-actions]

Hi @mikejolley, @senadir,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[mikejolley]

I got your testing steps to work, but there are some improvements we can make to the cache. I left comments below.

[opr]

@mikejolley I also added PHP unit tests for this.

[mikejolley]

Thanks for making those improvements @opr

Happy with this so pre-approving. However the CI linting rules are not happy with the tests so make sure to appease the CI before merging.

[senadir]

Not all blocks are PHP registered, but this should work.

[senadir]

Approving this, I'd wish we don't really need this for now, but I can't think of something else.