-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add srcset to Single Product gallery thumbnail images #49112
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Size Change: 0 B Total Size: 2.5 MB |
Hi @WunderBart, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
098f43d
to
a7537e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, product thumbnails have the srcset
attribute and they always stay sharp. Nice improvement, thanks! 🚀
* Add srcset to Single Product gallery thumbnail images * Add changelog file
* Add srcset to Single Product gallery thumbnail images * Add changelog file
Changes proposed in this Pull Request:
Fixes #48431.
This PR adds a
srcset
attribute to thumbnail images displayed in the Single Product page for products that have multiple images or variable products with different images for each variation.How to test the changes in this Pull Request:
srcset
attribute.(Note: you might to open the PRs in a new tab to see the difference)
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment