Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agents are removed even though they have tasks assigned #50

Closed
qwerty287 opened this issue Nov 8, 2023 · 3 comments · Fixed by woodpecker-ci/woodpecker#3378
Closed

Agents are removed even though they have tasks assigned #50

qwerty287 opened this issue Nov 8, 2023 · 3 comments · Fixed by woodpecker-ci/woodpecker#3378
Labels
bug Something isn't working

Comments

@qwerty287
Copy link
Contributor

This happens pretty often on ci.woodpecker-ci.org.
Agents are removed, even though there are tasks assigned to them (you can see this in the queue admin tab). The tasks have not started yet though.

Example (until it's canceled or restarted): https://ci.woodpecker-ci.org/repos/3780/pipeline/9626 (docker and securityscan)
@qwerty287 qwerty287 added the bug Something isn't working label Nov 8, 2023
@xoxys
Copy link
Member

xoxys commented Nov 8, 2023 •
edited

Yes, have seen this too on my setups. IMO, this is a server issue. The problem is, for the autoscaler the waiting on dependencies status is excluded from the calculation, but the server won't move an item from waiting on dependencies to e.g. pending without an available agent for whatever reason.

@xoxys
Copy link
Member

xoxys commented Nov 8, 2023

Might be (partially) related to woodpecker-ci/woodpecker#2685

@runephilosof-karnovgroup
Copy link

The draining is not working agent option "stop agent from taking new tasks" not working
So a task might be given to an agent just before it shuts down.

@qwerty287 qwerty287 mentioned this issue Jan 22, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
6543 pushed a commit to woodpecker-ci/woodpecker that referenced this issue Feb 12, 2024
@anbraten
Prevent agent deletion when it's still running tasks (#3377)
65d88be 
It wont solve the underlying issues like
woodpecker-ci/autoscaler#50 completely, but
should be a first step in the correct direction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix agent polling anbraten/woodpecker
3 participants
@xoxys @qwerty287 @runephilosof-karnovgroup