Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Allow creating/updating the release discussion category #1

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 31, 2022

  • bump GitHub dep to v35.3.0 as this was introduced in v35.1.0
  • add new string flag "discussion-category" (+ env vars)
  • update release: only set category, if not set
  • NOTE: Currently it looks like release drafts with discussion category
    set do not "persist" the category when being released, so when
    publishing a release draft, without explicitly setting the category, it
    won't have a release discussion. Nothing we can do here I suppose.

Signed-off-by: Thorsten Klein iwilltry42@gmail.com

source: drone-plugins/drone-github-release#89

iwilltry42 and others added 4 commits June 24, 2021 14:07
- bump GitHub dep to v35.3.0 as this was introduced in v35.1.0
- add new string flag "discussion-category" (+ env vars)
- update release: only set category, if not set
- NOTE: Currently it looks like release drafts with discussion category
set do not "persist" the category when being released, so when
publishing a release draft, without explicitly setting the category, it
won't have a release discussion. Nothing we can do here I suppose.

Signed-off-by: Thorsten Klein <iwilltry42@gmail.com>
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@6543 6543 merged commit 1cc2469 into master Jan 31, 2022
@6543 6543 deleted the feature/release-discussions branch January 31, 2022 18:02
@6543 6543 added this to the v1.1.0 milestone Jan 31, 2022
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 15, 2023
@pat-s pat-s added the feature Add new feature label Oct 15, 2023
@woodpecker-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Add new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants