Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for backend options #896

Closed
anbraten opened this issue Apr 29, 2022 · 0 comments · Fixed by #1645
Closed

Add flags for backend options #896

anbraten opened this issue Apr 29, 2022 · 0 comments · Fixed by #1645
Labels
refactor delete or replace old code

Comments

@anbraten
Copy link
Member

We added some backend options like WOODPECKER_BACKEND_SSH_ADDRESS in #893 and #861 which are accessed by os.Getenv directly. As the backend can be executed by the agent and by the cli exec command those settings need to be available for both and should be listed in the documentations of both systems.

To properly use them with urfave cli we should think about placing a flags.go file into each backend package and include this in the cli exec and agent options. This would allow us to see those options in the help of both tools and auto document them.

@6543 6543 added refactor delete or replace old code backend/ssh labels May 12, 2022
qwerty287 added a commit to qwerty287/woodpecker that referenced this issue Mar 18, 2023
6543 pushed a commit that referenced this issue Mar 19, 2023
- backends: move to cli flags instead of os.Getenv
- ssh: support 2fa with key and password
- allow to set grpc jwt secret (solves todo)
- allow to set default and max timeout (solves todo)

Closes #896
Closes #1131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants