Move entirely to zerolog #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
|
Some of the changes are likely because of running I'll do a bit more cleanup and commit the suggestions here. 👍 |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
|
|
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
6543
reviewed
Oct 10, 2021
|
@jolheiser Is it ready [... to review]? |
|
Should be. I ran it lightly locally, but I haven't yet gotten the hang of the ins and outs of testing CI locally haha |
7 tasks
6543
approved these changes
Oct 12, 2021
|
did remove addition of lint tool - I tested it and it did not throw an error ... @jolheiser can you add the lint tool in a seperate pull and add it to the pipeline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP, I haven't had a chance to run it yet.
As a larger refactor I also ran
goimportsagainst the whole project...which seems to have made a bit more noise than I intended.Let me know if you'd like me to try and make it more incremental.
This PR removes
logrus(and stdliblogwas used in a few places).It is a start towards #370, however it doesn't add much structured logging. I figured this was already noisy enough and structure could be done in a later PR.