Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runqftasm.sh friendlier for Ubuntu 18.04 #1

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

shinh
Copy link

@shinh shinh commented Apr 18, 2021

Also use set -e to make it easier to identiy failed commands.

Also use `set -e` to make it easier to identiy failed commands.
@woodrush woodrush force-pushed the master branch 3 times, most recently from bf23236 to ec6792f Compare April 20, 2021 03:28
@woodrush
Copy link
Owner

woodrush commented Apr 20, 2021

Sorry, I accidentally force-pushed to this repository before noticing your pull request. Could you please rebase it to the current head so I could merge it?
Sorry, never mind, I decided to roll back my master branch, merge your commit, and put my further edits on top of your commit. Thanks for the pull request!

@woodrush
Copy link
Owner

woodrush commented Apr 20, 2021

@shinh Sorry, I messed up on rebasing and merging the pull request, and accidentally ended up with this commit history (add-qftasm-backend), which has a duplicate commit. I squashed the three top commits on this branch and got this commit history (master) which removes the duplicate, but the "Verified" badge on GitHub's merge commit disappeared. If we want to keep the "Verified" badge, we could send a pull request to this branch (add-qftasm), and merge your commit there again. We could also keep the current master branch which has no duplicate but without GitHub's merge commit. How should we handle this? I'm sorry for the complications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants