Fixed invalid resource id

[piotrbelina]

Hello everyone,

I submit a small for an error I found.

When an user submits a request with an ID which is not string, he receives PHP type error instead of exception.

For example

PATCH /api/v1/sometypes/1 HTTP/1.1
Content-Type: application/json

{
  "data": {
    "type": "sometypes",
    "id": 1,
    "attributes": {
      "foo": "bar"
    }
  }
}

Actual error:

Type error: Argument 1 passed to WoohooLabs\Yin\JsonApi\Exception\ResourceIdInvalid::__construct() must be of the type string, integer given

Expected exception:

WoohooLabs\Yin\JsonApi\Exception\ResourceIdInvalid: The resource ID '1' must be a string!

Best regards,
Piotr Belina

[kocsismate]

Hey Piotr,

This is an awesome fix :) Probably I was too eager to type-hint everything :D So I'll release your fix very soon (hopefully today).

Cheers,

Máté

[piotrbelina]

Hi Máté,

Thank you for your quick response and the merge :)
Feel free to merge it to master also (since this pull request was for release 2.0.0 - I'm using version 2 because it supports php 7.0).
I would appreciate very much 2.0.5 tag so it would appear on packagist :)
Cheers,
Piotr

[kocsismate]

I've just released v2.0.5 :) And 3.0.1 is on its way along with other changes!