-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with yarn P'n'P #23
Comments
It can’t work, see #10. |
Yeah, I looked through that issue, and hope the yarn berry team can help. |
This isn't a PnP issue, more a missing import-meta-resolve feature (standard Node.js loader support), see #10 (comment) |
I think we'd better discuss in this new issue instead of the closed one. So I quoted @arcanis's comment here.
|
|
Joun, what you are asking for is that people have to specify |
@wooorm I don't think that's the solution? ![]() |
Yes that’s a loader. Someone has to use it? |
It sort of does that. It can’t exactly, because your CLI calls Node: https://github.com/conventional-changelog/commitlint/blob/87b1d36d23005b9c1d010ff6a49d1de7f4888cfe/%40commitlint/cli/cli.js. Use
|
What do you mean by
There is
When use yarn, the user must use
I'd love to, but we're still targeting on Node < 20, and the second parameter is still experimental.
Understand, I'm fine with not supporting loaders(or yarn P'n'P actually) personally. |
I think it’s interesting, the Yarn PnP thing. But it intentionally does lots of things differently. As you show, it has to wrap CLIs and As for supporting loaders, I think it would be a lot of work. Also to maintain. I don’t think anyone is interested in doing that work. See #10 (comment). |
Same as #10
See also conventional-changelog/commitlint#3936
I also tried
yarn unplug
:Reproduction: https://github.com/JounQin/test/tree/repro/commitlint
Steps:
yarn install
yarn commitlint --from
Related source codes:
import-meta-resolve/lib/resolve.js
Lines 994 to 1038 in 411516a
The text was updated successfully, but these errors were encountered: