fix: fallback to resolve-from for Yarn P'n'P
#3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JounQin
changed the title
require.resolve for Yarn P'n'P
JounQin
changed the title
require.resolve for Yarn P'n'Presolve-from for Yarn P'n'P
This was referenced Feb 28, 2024
escapedcat
reviewed
Feb 28, 2024
| throw resolveError; | ||
| try { | ||
| /** | ||
| * Yarn P'n'P does not support pure ESM well, this is only a workaround for |
There was a problem hiding this comment.
I guess we're not the only project breaking yarn p'n'p projects with a new major version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #3936
Motivation and Context
This is only a workaround for Yarn P'n'P + pure ESM, but it's also good enough.
We'll still watch wooorm/import-meta-resolve#23
Usage examples
How Has This Been Tested?
Types of changes
Checklist: