Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package exports array resolution #21

Closed

Conversation

helmturner
Copy link

@helmturner helmturner commented Jan 20, 2024

fixes: #20

  • Added tests
  • All tests passing
  • Not a breaking change

Because of the nature of the bug, it's not really possible that people are relying on the old behavior—as that would mean they are a) resolving to a non-existent file, or b) the first file exists anyway, which wouldn't be affected by this change.

@helmturner helmturner marked this pull request as draft January 20, 2024 07:36
@helmturner helmturner marked this pull request as ready for review January 20, 2024 07:46
@helmturner
Copy link
Author

Oops, I see it now... Just an issue with my test 😅

After correcting the name of the test module, the tests are now passing. Should be good to go.

@helmturner
Copy link
Author

Closing as this is an upstream issue:
nodejs/node#37928

@helmturner helmturner closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First item is always resolved when export map target is Array (even if non-existent)
1 participant