Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard edits #42

Closed
wants to merge 7 commits into from
Closed

Conversation

tvquizphd
Copy link
Contributor

@tvquizphd tvquizphd commented Jan 10, 2021

This is a new version of PR #39 to update only the keyboard edits. It ignores the new issue of inconsistent casing while fixing the issue of unexpected capital letters and the issue with keyboard groups.

This closes issue #37, closes issue #41, and ignores issue #46.

All tests have been updated to allow the continuous integration to pass.

It's ready to merge!

Comment on lines +502 to +506
st.deepEqual(
us.suggest('ToDo'),
['doDo', 'TOD', 'TODD', 'Togo', 'Tojo', 'too', 'Toto'],
'TODO: This test behaves unexpectedly, but is needed for coverage.'
)
Copy link
Contributor Author

@tvquizphd tvquizphd Jan 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is needed for the coverage to reach 100% including line #236 of suggest.js. Otherwise, no comparison is ever made when sorting suggestions of equal weight where element a has better casing than element b. This test is not needed by PR #45 or PR #39.

@tvquizphd
Copy link
Contributor Author

Closing in favor of PR #39.

@tvquizphd tvquizphd closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant