Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization #43

Closed
wants to merge 2 commits into from
Closed

Conversation

tvquizphd
Copy link
Contributor

@tvquizphd tvquizphd commented Jan 10, 2021

This contains fixes previously bundled in PR #39.
This adds new tests (that currently fail on main), and it breaks some existing tests.
Before we could merge this PR, we would need to merge PR #39 and PR #44.

I've found a few miscellaneous capitalization issues with main that I thought I'd address. I'm operating under a few assumptions I've made by observing the general behavior of nspell/main:

  • UPPERCASE INPUT should always produce UPPERCASE OUTPUT
  • Sentence Case Input should produce Sentence Case Output
    • unless the output is in the dictionary as UPPERCASE
  • lowercase input should output lowercase
    • unless the output is in the dictionary as Sentence Case or UPPERCASE
  • FuNkY caSE should output FuNkY caSE
    • unless the output is in the dictionary as Sentence Case or UPPERCASE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant