Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for too many Variations #5527

Closed
swarnat opened this issue May 21, 2014 · 10 comments
Closed

Fix for too many Variations #5527

swarnat opened this issue May 21, 2014 · 10 comments

Comments

@swarnat
Copy link

swarnat commented May 21, 2014

Hy,
I create a shop for a client with > 100 variations in one variable product and create a fix to increase the performance and remove the max_input_vars modification, which isn't possible for the related webhost.
This fix come in a single plugin, without any hacks into woocommerce.

I implement a external pagination for variations.
Thanks to the intelligent codebase of woocommerce this could be done easily.

But I'm not sure if it is a good idea, how I solve this and if I will run into another trouble.
At the moment it is limited and don't have the best usability. But it works and could be extended.

Look here:
https://github.com/Odermedia-GmbH/WooCommerce-ManyVariations

I create this issue, because this will be a good solution for the woocommerce core and work out of the box.

Odermedia

@BFTrick
Copy link
Contributor

BFTrick commented May 23, 2014

Thanks for the code here. If you look at our roadmap we have several things planned for a variations rewrite. Being able to edit a product with hundreds of variations has come up before and will be something we look into.

For right now though this isn't high priority since most users have access to their php settings and can implement the fix: http://docs.woothemes.com/document/problems-with-large-amounts-of-data-not-saving-variations-rates-etc/

Since this is a stand alone plugin have you thought about releasing it on WordPress.org? Then users who don't have access to their php settings can use that until we come up with some other way around this.

@swarnat
Copy link
Author

swarnat commented May 24, 2014

Hy,
Thanks for your response. The main reason for this fix wasn't the max_input_vars limit, but this is a side effect, too.
The main reason was the load/save time of the product page in backend, which is too long for >30 variations.

But I was not sure if I call any problems. I can't see at the moment, If I done save all variations at once.

I will go the way with wordpress.org.
Thansk!
Stefan

@mikejolley
Copy link
Member

#5357

@Reberholt
Copy link

Do you people even try to understand the problem ? The WooCommerce don´t work as it is now ? how cna you say this isn't high priority ?

@ethanpil
Copy link

+1000 on this is issue! This is a crippling problem for many large e-commerce shops.

Many variations causes two problems:

  1. Very slow JS rendering of page (Addressed here by @swarnat )
  2. Too many input fields submitted to server ( Addressed on http://docs.woothemes.com/document/problems-with-large-amounts-of-data-not-saving-variations-rates-etc/)

@opusuno
Copy link

opusuno commented Dec 15, 2015

Same problem. Custom products need lot's of options. Unusable.

I don't think it should be a closed topic unless there's some magic fix I'm not finding.

@swarnat
Copy link
Author

swarnat commented Dec 15, 2015

Hy,
Since the version 2.4 this is no problem anymore, because the variations are loaded by a pagination in backend.
The developer implement a very good handling of the variation configuration.
Stefan.

@opusuno
Copy link

opusuno commented Dec 16, 2015

Thanks, but I have a 2.4.12 site that is at a crawl. I’ve changed the max_input_vars and maxed the memory.

Still, the only products that are slow are the one’s with several variations. 9+ seconds to load a page.

Any help is appreciated.

Steve B.

steve@opusuno.com

On Dec 15, 2015, at 3:28 PM, Stefan Warnat notifications@github.com wrote:

Hy,
Since the version 2.4 this is no problem anymore, because the variations are loaded by a pagination in backend.
The developer implement a very good handling of the variation configuration.
Stefan.


Reply to this email directly or view it on GitHub #5527 (comment).

@pixelmultiplo
Copy link

+1000, Woocommerce can't handle a simple 100+ variations, it's a pretty common situation with clothing color/size. Is the plugin abandoned or what?

@mikejolley
Copy link
Member

As has been pointed out above, the backend has pagination, and the frontend uses ajax if you have > 30 variations. If your ajax calls are slow in general, thats a separate, potentially server or plugin, issue.

I don't see a reason to leave this issue open - the OP issue has been resolved.

#5527 (comment)

@woocommerce woocommerce locked and limited conversation to collaborators Nov 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants