Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for table inheritance #389

Closed
chihabhajji opened this issue Dec 15, 2023 · 2 comments
Closed

add support for table inheritance #389

chihabhajji opened this issue Dec 15, 2023 · 2 comments

Comments

@chihabhajji
Copy link

chihabhajji commented Dec 15, 2023

Hello, Jeongmin Lee, jiho-kr , all the woowabros, and all the maintainers of this repo, first of all thank you for this amazing library.
I'm a novice in nestjs and TypeORM especially, so id really appreciate if someone can guide me on how i can help resolve the issue of not being able to use table inheritance.
The route factory is unable to resolve the entity name (i tried matching if the type of the table is not entity-child, but that led to "Cannot read properties of undefined (reading 'ownColumns')").
I started with unit tests (read-many only for now).
PR: #388

@jiho-kr
Copy link
Contributor

jiho-kr commented Dec 16, 2023

hi @chihabhajji

I checked this issue(#389) and PR(#388).

It has been confirmed that ChildEntity is not currently supported.
I have added a new PR(#390) in place of the PR you contributed to support ChildEntity and hope this helps you.

@chihabhajji
Copy link
Author

thank you ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants