Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table inheritance support #388

Closed

Conversation

chihabhajji
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

using

@TableInheritance
and
@ChildEntity
for table inheritance causes the factory to throw 'Cannot find Entity name from TypeORM'

Issue Number: N/A

What is the new behavior?

This is still a WiP, but i want guidance on how to fix the library to support table inheritance and without causing regressions

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chihabhajji
Copy link
Author

#389

@jiho-kr
Copy link
Contributor

jiho-kr commented Dec 16, 2023

Thanks for your contribution.

The entity inheritance feature is supported in MR#390.

You will be able to close this PR after sufficient review.

@chihabhajji
Copy link
Author

closed by #390 , but i'm still looking for that contribution mark, will find another issue to solve 🤣

@chihabhajji chihabhajji deleted the feat/support-entity-child branch December 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants