[유안] 체스 미션 4~5단계 제출합니다 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
빈 보드 판 html, css 작
DB를 이용할 수 있도록 미리 fakeDAO 이용해서 로직 수
(웹 UI 메뉴 버튼 추가)
점수 구하는 로직에 폰 관련 오류 수
로컬에서 DB에 연결 된 것 처럼 작동하던 가짜 DAO 대신 MySQL과 연결할 수 있는 DAO 구현
WebRequest enum 만들어서 요청 처리 분
웹 UI 적용하며 변경된 코드들 테스트 수정
young891221
suggested changes
Apr 7, 2020
src/main/resources/public/js/main.js
Outdated
| } else { | ||
| document.getElementById("movableStart").value = element.id; | ||
| document.getElementById("movableCommand").value = "이동체크"; | ||
| document.getElementById("movableForm").submit(); |
There was a problem hiding this comment.
document.getElementById("movableForm").submit();
은 한번만 쓰도록 리펙토링 가능해 보이네요ㅎㅎ
src/main/resources/public/js/main.js
Outdated
| document.getElementById("moveForm").submit(); | ||
| } else { | ||
| document.getElementById("movableStart").value = element.id; | ||
| document.getElementById("movableCommand").value = "이동체크"; |
There was a problem hiding this comment.
"이동", "이동체크"만 value로 묶어서 리펙토링 가능해 보입니다.
There was a problem hiding this comment.
추가로 말씀하셨던 moveStart에 대한 리펙토링은
검색할 때 한번 탐색하고
대입할 때 탐색할 수밖에 없다고 생각해 진행하지 않았습니다.
| public static Map<String, Object> parseBlankBoard() { | ||
| return Position.getAllPositions() | ||
| .stream() | ||
| .collect(toMap(Position::toString, position -> "blank")); |
|
|
||
| // 드라이버 연결 | ||
| try { | ||
| con = DriverManager.getConnection("jdbc:mysql://" + server + "/" + database + option, userName, password); |
| System.out.println("정상적으로 연결되었습니다."); | ||
| } catch (SQLException e) { | ||
| System.err.println("연결 오류:" + e.getMessage()); | ||
| e.printStackTrace(); |
|
|
||
| // 드라이버 연결 | ||
| try { | ||
| con = DriverManager.getConnection("jdbc:mysql://" + server + "/" + database + option, userName, password); |
Comment on lines
21
to
25
| String server = "localhost:13306"; // MySQL 서버 주소 | ||
| String database = "db_name"; // MySQL DATABASE 이름 | ||
| String option = "?useSSL=false&serverTimezone=UTC"; | ||
| String userName = "root"; // MySQL 서버 아이디 | ||
| String password = "root"; // MySQL 서버 비밀번호 |
young891221
suggested changes
Apr 8, 2020
| public void placePieceOn(Position position, Piece piece) throws SQLException { | ||
| String query = "INSERT INTO board (position, piece) VALUES (?, ?) ON DUPLICATE KEY UPDATE position=?, piece=?"; | ||
|
|
||
| try (Connection con = DriverManager.getConnection(String.format("jdbc:mysql://%s/%s%s", SERVER, DATABASE, OPTION), USER_NAME, PASSWORD); |
There was a problem hiding this comment.
이거를 필드로 빼면 한번만 포맷팅해서 사용하면 될 듯 보입니다.
String.format("jdbc:mysql://%s/%s%s", SERVER, DATABASE, OPTION), USER_NAME, PASSWORD)| public Optional<Piece> findPieceOn(Position position) throws SQLException { | ||
| String query = "SELECT * FROM board WHERE position = ?"; | ||
|
|
||
| try (Connection con = DriverManager.getConnection(String.format("jdbc:mysql://%s/%s%s", SERVER, DATABASE, OPTION), USER_NAME, PASSWORD); |
There was a problem hiding this comment.
아래와 같은 형식이 계속 반복되는 데요. 인터페이스를 열어두어 ...만 변경되고 공통된 형태는 재활용 하도록 리펙토링 부탁드립니다.
Connection con = getConnection();
PreparedStatement pstmt = con.prepareStatement(query);
...
pstmt.executeUpdate();
pstmt.close();
closeConnection(con);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
감사합니다.