-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear message if a media was not uploaded #10370
Comments
@shiki Hey thanks for bringing it up. I chatted to @maxme and @malinajirka about this a while ago IIRC. Its an unusual case because (AFAIK) we do not know why the media didn't upload. My ideal case would be
But as far as I'm aware, because we don't know why the media didn't upload we need to generalise the error for both online/offline. So a user could try upload a photo while online and there's some issue with the file, obviously we can't give them that offline error. We need a general 'couldn't upload' error which is why we ended up with this. |
@osullivanchris Just an idea: |
My concern with showing that “Could not upload media” error is because the post may still get automatically published anyway. The user will get surprised because there is no indication that this will happen. I'm not quite sure how we can fix this in a short time frame though. Could we perhaps tie this to the maximum number of retries? The maximum right now is 10. WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/uploads/UploadActionUseCase.kt Line 16 in c25d4aa
Maybe we can make that lower. So something like this would be the experience:
|
Not a bad idea but I think we have a pattern of displaying text in the same place if there is a relevant status of that post. If I was adding an icon I would add it in-line with the text. I don't think an icon by itself would be enough to explain as the concepts around states and uploading are quite specific and sometimes abstract.
Here I would make a change. I would make an exception that if this 'Could not upload media' error occurs, we do not Autoupload the post until the user resolves the error. For the reason that you stated. It would be a bad experience if you try to publish a photo or some other media and the post publishes without that media. |
I think it's not a bad idea. I'd need to look into it, but I think it should work without a significant performance impact.
Yep, that's something I was thinking about as well. I like having icons wherever possible so it'd definitely be a minor improvement as well. However, it wouldn't help us in solving this issue. I was basically thinking that we could start a new pattern with status icons in the top right corner so we could show more than one statuses at a time -> Eg. Error icon + Auto-Upload icon -> we'd still be showing only the error label, but some users would also see that we'll retry auto-upload without their interaction. But either case we won't make this change now anyway:D I just wanted to share my idea.
We never (unless there is a bug) upload or auto-upload a post without its media. So if there is a media file which hasn't been uploaded yet we won't even start uploading/auto-uploading the post itself.
|
Ah thanks @malinajirka that makes sense to me now! In that case I think what @shiki suggested around retry numbers and different copy sounds good to me. Only issue with that solution is we could end up with the reverse user scenario that @malinajirka described. A user could see a message saying it will be uploaded when online, and not see the updated message when retry count reaches 3. |
This is the current behavior anyway. The auto-upload(retry) is limited to 10 retries. Moreover we show an error notification when an upload fails. |
@osullivanchris Sorry, I got lost in the conversation. What is the different copy? |
Decision made in this conversation Show
I believe Chris meant different copy on 3rd+ retries. |
@malinajirka @osullivanchris I updated the description with the decision. |
I wasn't able to implement this without making significant changes or having an unreliable error handling. We also realized that when we show an upload error, the user can't cancel the auto-upload action, since the "Cancel" action gets replaced with "Retry". After a discussion with @osullivanchris we decided to do the following in v1 of Offline Support project:
Media upload error:
Post upload error:
*Published/submitted/saved/scheduled |
Done in #10446 |
This was from #10319 (comment) and can only be reproduced when using the
master-auto-upload
branch.In #10319, we will automatically publish posts if the user has explicitly pressed the Published. This now works. However, when a post has pending or failed media uploads, we do not see the “Post will be published next time your device is online” error message as described in wordpress-mobile/WordPress-iOS#12227. We see this instead:
Steps to reproduce
Decision 2019-Aug-27
This was decided on a Slack conversation. We will limit the retry count to 3.
Media upload error:
Post upload error:
*Published/submitted/saved/scheduled
The text was updated successfully, but these errors were encountered: