Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-signup interstitial feature #11024

Merged
merged 30 commits into from
Dec 24, 2019

Conversation

renanferrari
Copy link
Member

Master issue: #10918

Related tasks:


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

renanferrari and others added 30 commits December 9, 2019 20:26
…titial-screen

Post-Signup Interstitial: Create interstitial screen
…stitial-screen

Post-Signup Interstitial: Display interstitial screen
…not-shown-after-magic-link-login

Fix post-signup interstitial for login with magic link
…itial-screen-events

Post-Signup Interstitial: Track interstitial screen events
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 24, 2019

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

This PR contains changes in the subtree libs/mocks/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPressMocks. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout feature/10918-post-signup-interstitial
  3. git subtree push --prefix=libs/mocks/ https://github.com/wordpress-mobile/WordPressMocks.git merge/WordPress-Android/11024
  4. Browse to https://github.com/wordpress-mobile/WordPressMocks/pull/new/merge/WordPress-Android/11024 and open a new PR.

Generated by 🚫 dangerJS

@renanferrari renanferrari changed the title Adds post-signup interstitial feature Add post-signup interstitial feature Dec 24, 2019
@maxme maxme added this to the 14.0 milestone Dec 24, 2019
@maxme maxme self-assigned this Dec 24, 2019
@maxme maxme self-requested a review December 24, 2019 17:04
@maxme maxme added the Signup label Dec 24, 2019
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're merging the feature branch feature/10918-post-signup-interstitial where all smaller PRs were reviewed. I did some more manual tests and had a look at our analytic tools to make sure we tracked the correct events.

:shipit:

@maxme maxme merged commit e28dd5b into develop Dec 24, 2019
@maxme maxme deleted the feature/10918-post-signup-interstitial branch December 24, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants