-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add android complete codefreeze #13215
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as described in PR body but also tested by running be complete_code_freeze
on a non-release branch and validated it printed the right error and stopped. All good 👍
fastlane/Pluginfile
Outdated
@@ -6,5 +6,5 @@ group :screenshots, optional: true do | |||
gem 'rmagick', '~> 4.1' | |||
end | |||
|
|||
gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', tag: '0.9.14' | |||
gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', ref: 'a53b7c2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could put in place a Peril check for this, like we do for our pods.
Every time we do this kind of PRs, either the author writes this or a reviewers points it out. 😄 If we automate it, we'll get the benefit of actually blocking the merge.
This PR adds the
complete_code_freeze
lane to this project.At this point, the Android lane only runs the usual prechecks (make sure git repo is clean, make sure a release branch is checked out, confirm the version with the user) and pushes the tags.
Related
release-toolkit
PR: wordpress-mobile/release-toolkit#169To test:
release/test
branch from this one and push it.build.gradle
for both the beta and the alpha, and commit.bundle exec fastlane complete_code_freeze
.Clean up:
Note: After review and approval, before merging this PR, I'll release a new version of
release-toolkit
and update the reference to the released version,PR submission checklist:
RELEASE-NOTES.txt
if necessary.