Feature/add android complete codefreeze #13215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
loremattei
requested review from
a team,
AliSoftware,
jkmassel and
mokagio
and removed request for
a team
AliSoftware
approved these changes
Oct 23, 2020
AliSoftware
reviewed
Oct 23, 2020
fastlane/Pluginfile
Outdated
| @@ -6,5 +6,5 @@ group :screenshots, optional: true do | |||
| gem 'rmagick', '~> 4.1' | |||
| end | |||
|
|
|||
| gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', tag: '0.9.14' | |||
| gem 'fastlane-plugin-wpmreleasetoolkit', git: 'https://github.com/wordpress-mobile/release-toolkit', ref: 'a53b7c2' | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I guess we could put in place a Peril check for this, like we do for our pods.
Every time we do this kind of PRs, either the author writes this or a reviewers points it out. 😄 If we automate it, we'll get the benefit of actually blocking the merge.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
complete_code_freezelane to this project.At this point, the Android lane only runs the usual prechecks (make sure git repo is clean, make sure a release branch is checked out, confirm the version with the user) and pushes the tags.
Related
release-toolkitPR: wordpress-mobile/release-toolkit#169To test:
release/testbranch from this one and push it.build.gradlefor both the beta and the alpha, and commit.bundle exec fastlane complete_code_freeze.Clean up:
Note: After review and approval, before merging this PR, I'll release a new version of
release-toolkitand update the reference to the released version,PR submission checklist:
RELEASE-NOTES.txtif necessary.