Themes: Fix theme url to include the correct image resized url #15060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
|
Matching iOS PR wordpress-mobile/WordPress-iOS#16914 |
chipsnyder
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
This looks good to me. Thanks for porting this over @antonis.
I added a release note for @enejb's PR I'm not sure if you'll want to copy that here or not.
|
Thank you for the review Chip 🙏
That's a good idea. I've copied the release note with e0d1b56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the URL that we genetate to display the theme screenshots.
Before: https://i2.wp.com/s2.wp.com/wp-content/themes/pub/blank-canvas/screenshot.png?ssl=1?w=409
After: https://i2.wp.com/s2.wp.com/wp-content/themes/pub/blank-canvas/screenshot.png?ssl=1&w=409
The fix should download smaller images for each of the themes saving bandwidth and mobile data.
This issue was discoverd while trying to clear the screenshot image cache for the blank-canvas theme.
To test:
Navigate to the theme selection screen for a .com site. Notice that the screenshots show up as expected.
.org sites do not have the theme selection as an option.
Navigate to an atomic and jetpack site notice that the themes show up as expected.
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Adding a test for the code change would require changing the architecture of the specific part of the code. The effort needed for this might not be justified by the task at hand.
PR submission checklist:
RELEASE-NOTES.txtif necessary.