Post list filter by status #9233
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
@malinajirka I did an initial pass of this PR just to see how things are shaping up and it looked good to me. I'll do the actual review once #9226 is merged.
Just a quick reminder that we'll need to update the empty views for different tabs as it doesn't make sense to say No posts yet. Why not create one? in Trashed posts. I think it's worth opening a separate issue for this, but maybe you want to handle it in this PR, so I haven't done that yet.
WordPress/src/main/java/org/wordpress/android/ui/posts/PostsListActivity.java
Show resolved
Hide resolved
…st-filter-by-status # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/PostsListActivity.java # WordPress/src/main/java/org/wordpress/android/ui/posts/PostsPagerAdapter.kt
|
Thanks @oguzkocer !
Good point! I've created a ticket #9240 |
oguzkocer
changed the base branch from
issue/9180-post-list-viewpager
to
feature/master-post-filters
There was a problem hiding this comment.
I think we'll need to change some stuff in the PostListViewModel, but with the understanding that this is a WIP, I think everything looks great 
My comment from earlier is not a blocker and can be done as part of any other PR, so I am just going to merge this in to keep things moving.
WordPress/src/main/java/org/wordpress/android/ui/posts/PostListAction.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/viewmodel/posts/PostListViewModel.kt
Show resolved
Hide resolved
Fixes #4693
NOTE: update the target branch to "feature/master-post-filters" when #9226 is merged.
Adds support for filtering posts by their status.
Adds logic to display FAB (new post button) only on Scheduled and Drafts tabs.
To test:
Update release notes:
RELEASE-NOTES.txt.