Quick Start for Existing Users V2 - Refactor code to support different quick start types (FluxC) #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to have two sets of tasks, one for each of quick start types (for new site and existing site) to be added in future commits. This will allow to add a common task like check_stats with same enum constant in each set.
This is done to retrieve unique task based on task name and task type as we do not store quick start type in db.
3 tasks
ashiagr
force-pushed
the
issue/16350-refactor-for-different-qs-types-fluxc
branch
from
e6207ca
to
3302ccc
Compare
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
AjeshRPai
approved these changes
May 11, 2022
There was a problem hiding this comment.
I have looked at the code changes and tested it as per the instructions. Everything looks good to me. Great Job @ashiagr. 👍 🙌 .
I left a nitpick, please feel free to merge once you have addressed it. Approving the PR as the Nitpick is non blocking.
fluxc/src/main/java/org/wordpress/android/fluxc/store/QuickStartStore.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent wordpress-mobile/WordPress-Android#16350
This PR splits
QuickStartTaskinto two different sets of tasks for different quick start types.PS: Currently, no new tasks are added to the "existing site" quick start type.
How to test?
See corresponding WPAndroid PR: wordpress-mobile/WordPress-Android#16500