Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images broken if previewing a Post without updating it first #13929

Closed
ngoctr opened this issue Apr 16, 2020 · 2 comments · Fixed by #13974
Closed

Images broken if previewing a Post without updating it first #13929

ngoctr opened this issue Apr 16, 2020 · 2 comments · Fixed by #13974

Comments

@ngoctr
Copy link
Contributor

ngoctr commented Apr 16, 2020

Describe the bug
While we were working on this, we had noticed an issue where previewing in the Block Editor while images being uploaded: Ref #13910 (review)

To Reproduce
Steps to reproduce the behavior:

  1. From WordPress app, Go to Site -> Posts then select a Post to edit. Switch to Block Editor if you're on the classic editor.
  2. Add an Image block, then tap ADD IMAGE and choose Free Photo Library
  3. Search and select an image of your choice
  4. While the image being uploaded, Tap the ... menu at the top-right corner, select Preview, you will the image being broken.

Expected behavior
In my opinion, since the image has not been uploaded yet so the preview won't be able to show the image. However, the Preview button is there, and it user would expect to see images when previewing a Post.

Screenshots
image

Smartphone (please complete the following information):

  • Device: [iPhone, iPad]
  • OS: [iOS]
  • Version [13.4]

Additional context
N/A

@maxme
Copy link
Contributor

maxme commented Apr 17, 2020

In my opinion, since the image has not been uploaded yet so the preview won't be able to show the image. However, the Preview button is there, and it user would expect to see images when previewing a Post.

I agree. In wpandroid (with classic or the block editor), we show a toast message ("You are currently uploading media. Please wait until this completes.") when the Preview button is pressed during an image upload.

Ref. https://github.com/wordpress-mobile/WordPress-Android/blob/a3988b1b990862b2e7ee16df6737c449a43349f1/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java#L1112

I think the same behavior should be implemented on wpios (I thought this was part of the preview revamp project cc @diegoreymendez @yaelirub)

@yaelirub
Copy link
Contributor

Thanks @maxme ! I'll add this to our backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants