Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Previewing a post while uploading image for image block #11835

Closed
JavonDavis opened this issue May 31, 2019 · 7 comments
Closed

Preview: Previewing a post while uploading image for image block #11835

JavonDavis opened this issue May 31, 2019 · 7 comments

Comments

@JavonDavis
Copy link
Contributor

Choosing Preview while image upload is still in progress opens preview with no image and going back to the post and making edits shows only new edits still without the image preview, only a little square

Expected behavior

Not sure how we'd like to handle the user trying to preview while an image upload in progress, my suggestion is to continue to the preview and show a template image in the interim until the upload is complete

Actual behavior

IMG_0019

Steps to reproduce the behavior

  1. Activate the block editor
  2. Add an image block
  3. Add an image to the image block
  4. Preview the post before the image upload is finished(this was easy for me but Network link conditioner might help to do this on a simulator)
  5. Optionally, go back to the post and make changes, previewing still shows the image as shown in the screenshot
Tested on [device], iOS [version], WPiOS [version]

iPhone 6, iOS 12.1.2, 12.5.0.2

@yaelirub
Copy link
Contributor

yaelirub commented Jun 2, 2019

Hey @JavonDavis , we have an open issue in progress for this : #11808

@JavonDavis
Copy link
Contributor Author

JavonDavis commented Jul 5, 2019

Hey @shiki @yaelirub I tested this on develop and I'm still seeing the same issue here, was I suppose to check out another branch?

@yaelirub
Copy link
Contributor

yaelirub commented Jul 8, 2019

@JavonDavis , I was able to reproduce. Let's keep #11808 and #11836 closed and work on this one as it best describes the issue.
Thank you for looking into this.

@yaelirub yaelirub self-assigned this Jul 8, 2019
@yaelirub
Copy link
Contributor

This issue is pure preview issue. Moving this to groundskeeping.

@shiki
Copy link
Member

shiki commented Sep 13, 2019

I found the same thing a week ago. Please see the description of #12481 for more technical details and steps. IIRC, I was using Aztec instead of Gutenberg.

@erricgunawan
Copy link

Just out of curiosity, is this issue the same or related with #13929 ? That one looks like already have a fixed here: #13974

I came to this (and the issue above) because of a report in 3126988-zen:

I have been trying to upload a blog post via ipad or iPhone but unfortunately whenever I hit preview the images won’t show only the content is shown. After showing error for uploading images it says Wordpress doesn’t support classic editor but even block editer option is not supporting to show or upload images while previewing.

I know that message might still be confusing so I'm confirming with the user.

But I just wonder if this issue itself already has a fix or this is still an issue at all.

@yaelirub
Copy link
Contributor

Hey @erricgunawan , thanks for commenting here! We disabled the option to preview post while uploading media so I think you're right and we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants