Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an alert when trying to preview while uploading media #13974

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

yaelirub
Copy link
Contributor

@yaelirub yaelirub commented Apr 23, 2020

Fixes #13929

To test (Classic and block editors - Please test on device):

  1. Go to My Site -> Posts then select a Post to edit.
  2. Add an Image / gallery block or classic
  3. While the image being uploaded, Tap the ... menu at the top-right corner, select Preview
  4. See the alert if image still uploading
  5. When Image done uploading, tap preview again
  6. See preview with the image

IMG_5993

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 23, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 23, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@leandroalonso
Copy link
Contributor

@yaelirub it worked smoothly in Gutenberg. However, I had a problem with Aztec: https://d.pr/v/98bx05

For some reason, the "local path" remains (something that was not introduced by your PR — it's there for some time).

Do you want to check that or shall we merge this one?

@yaelirub
Copy link
Contributor Author

I saw it and I think there's an issue for it.
AFAIK, out of scope for this PR

Co-Authored-By: Leandro Alonso <contato@leandroalonso.com>
@yaelirub yaelirub merged commit d798535 into develop Apr 23, 2020
@yaelirub yaelirub deleted the issue/13929_notice_on_preview_when_uploading branch April 23, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images broken if previewing a Post without updating it first
2 participants