-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stats Refresh] Period Referrers: fix displaying details view #11741
Conversation
…matter the image type (downloaded, gridicon, etc) it will be the correct size for the stat.
…DetailExpandableRow for parent rows and DetailExpandableChildRow for child rows.
downloadImageFrom(iconURL) | ||
} | ||
|
||
if let iconURL = rowData.userIconURL { | ||
imageWidthConstraint.constant = Constants.userImageSize | ||
imageView.layer.cornerRadius = Constants.userImageSize * 0.5 | ||
imageView.layer.cornerRadius = imageSize * 0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this code was in place previously, but it occurred to me that some might not understand the intent of this message.
If we're making the image view circular, it might be more clear to set the path for a mask via one of the following methods:
init(arcCenter:radius:startAngle:endAngle:clockwise:)
init(ovalIn:)
I don't feel strongly about this, but wanted to share.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScoutHarris this is working as described for me!
Ref #11360, #11080
This changes Period > Referrers to use
UITableViewCell
s instead of oneUIStackView
.Previously, all the data was stuffed into the stack view on the
TopTotalsCell
card. Now it only uses theTopTotalsCell
card to show the header viaDetailSubtitlesHeaderRow
. The stack view is left empty. Instead, aUITableViewCell
is added to the table for each data row via:DetailExpandableRow
- for parent rowsDetailExpandableChildRow
- for child rowsAnd, because Referrers
Search Engines
rows can be expanded twice, "grandchild" rows are now supported.This also addresses two other issues:
From #11080 - When no icon is available then show
gridicons-globe
.From #11674 (comment) - fix
gridicons-search
icon size.Update release notes:
RELEASE-NOTES.txt
.To test:
View more
.Search Engines
row: (tip: en.blog has this row)For an expandable row...
).