Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Settings Primary Site: show domain if site has no title #11803

Merged
merged 2 commits into from May 30, 2019

Conversation

@ScoutHarris
Copy link
Contributor

commented May 29, 2019

Fixes #11716 (original issue #5884)

This changes the Account Settings > Primary Site to display the domain (instead of the web address) if the site has no title. I checked Calpyso to ensure I got the right one this time, and it does appear to show the domain.

cc @designsimply

To test:


  • Go to Account Settings > Primary Site.
  • Select a site with no title, or remove the primary site title via Site Settings > Site Title.
  • Verify the domain is displayed.

no_title


  • Go to Account Settings > Primary Site.
  • Select a site with a title, or set the primary site title via Site Settings > Site Title.
  • Verify the title is displayed.

with_title


Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ScoutHarris ScoutHarris added the /Me label May 29, 2019

@ScoutHarris ScoutHarris added this to the 12.6 milestone May 29, 2019

@ScoutHarris ScoutHarris requested a review from nheagy May 29, 2019

@ScoutHarris ScoutHarris self-assigned this May 29, 2019

@ScoutHarris

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@nheagy - can I bother you for a review please? Thank you!

@nheagy

nheagy approved these changes May 30, 2019

Copy link
Contributor

left a comment

Looks great 😀

:shipit:

@ScoutHarris

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Thanks @nheagy !

@ScoutHarris ScoutHarris merged commit 23aa85c into develop May 30, 2019

3 checks passed

Hound No violations found. Woof!
Peril All green. Good on 'ya.
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details
@peril-wordpress-mobile

This comment has been minimized.

Copy link

commented May 30, 2019

Fails
🚫

Could not find Dangerfile at org/common.ts on wordpress-mobile/peril-settings on branch master

Full state of PR run:

{
"branch": null,
"dangerfileBranchForPR": "fix/11716-primary_site_url",
"neededDangerfileIsLocalRepo": false,
"repoForDangerfileRun": "wordpress-mobile/peril-settings",
"run": {
  "action": "closed",
  "dslType": 0,
  "event": "pull_request",
  "branch": "master",
  "dangerfilePath": "org/common.ts",
  "repoSlug": "wordpress-mobile/peril-settings",
  "referenceString": "wordpress-mobile/peril-settings@org/common.ts",
  "feedback": 0
},
"settings": {
  "commentableID": 11803,
  "eventID": "Unknown",
  "hasRelatedCommentable": true,
  "installationID": 678301,
  "installationSettings": {
    "env_vars": [],
    "ignored_repos": [
      "wordpress-mobile/peril-settings"
    ],
    "modules": []
  },
  "isRepoEvent": true,
  "isTriggeredByUser": true,
  "repoName": "wordpress-mobile/WordPress-iOS",
  "repoSpecificRules": {
    "pull_request, pull_request.labeled, pull_request.unlabeled": "wordpress-mobile/peril-settings@org/ios.ts"
  },
  "triggeredByUsername": "ScoutHarris"
}
}

Generated by 🚫 dangerJS

@ScoutHarris ScoutHarris deleted the fix/11716-primary_site_url branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.