Posts and Pages search: Update to Muriel color scheme #12124
Conversation
WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Pages/PageListSectionHeaderView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Activity/ActivityListSectionHeaderView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Activity/ActivityListSectionHeaderView.swift
Outdated
Show resolved
Hide resolved
| updateBackgroundColor() | ||
| } | ||
|
|
||
| // Update controller's background color to avoid white lines |
There was a problem hiding this comment.
Could we add just a little more clarification to this comment? Where was the white line and why was it appearing?
There was a problem hiding this comment.
Changed! Let me know what you think.
| @@ -83,6 +86,12 @@ class PostCompactCell: UITableViewCell, ConfigurablePostView { | |||
| contentView.backgroundColor = innerView.backgroundColor | |||
| } | |||
|
|
|||
| private func setupSeparator() { | |||
| WPStyleGuide.applyBorderStyle(separator) | |||
| contentView.heightAnchor.constraint(equalToConstant: contentView.frame.height + WPStyleGuide.separatorHeight).isActive = true | |||
There was a problem hiding this comment.
I'm not sure this should be necessary, if you ensure the InnerView is pinned to the top of the content view, and the bottom of the InnerView is pinned to the top of the separator?
There was a problem hiding this comment.
This code was adding the separator height to the cell height and realign the labels (to maintain the same margins as before the hardcoded separator). But yeah, complex and not so clear.
I removed it and managed to achieve the same result with a heigh constant in the xib.
This PR fixes the color and some design details in posts and pages search.
To test: