Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Migration to per-site editor setting and sync with server #12221

Merged
merged 63 commits into from
Jul 29, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Jul 29, 2019

To test:

WP.com/Jetpack sites

  • Create a new WP.com site on mobile and check Site Settings → should be Gutenberg.
  • Create a new WP.com site on mobile and start a new post → should be Gutenberg.
  • Clean app, clean backend, start new post → should be Aztec
  • Clean app, "Aztec" in backend, start new post → should be Aztec
  • Clean app, "Gutenberg" in backend, start new post → should be Gutenberg.
  • Clean app, clean backend, open Gutenberg post → auto-enables Gutenberg
  • Clean app, clean backend, open Gutenberg post (auto-enables GB), start new post → should be Gutenberg
  • Clean app, clean backend, open Gutenberg post (auto-enables GB), open a GB post again→ Gutenberg but no popup
  • Clean app, clean backend, open Gutenberg post (auto-enables GB), new post in other site → should be Aztec
  • Clean app, clean backend, open Gutenberg post (auto-enables GB), open GB post in other site → auto-enables Gutenberg.
  • Toggling the setting in a site doesn't toggle it in others
  • Migrate from v12.9 with GB ON, start new post → should be Gutenberg in all sites
  • Migrate from v12.9 with GB OFF and been auto-enabled, start new post → should be Aztec in all sites
  • Migrate from v12.9 with GB OFF and never auto-enabled, start new post → should be Aztec in all sites
  • Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and start new post → should be Aztec
  • Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and open GB post → auto-enables Gutenberg on the site.

Selfhosted sites

  • Self-hosted site added, start new post → should be Aztec

  • Self-hosted site added, open a GB post → auto-enables Gutenberg

  • Self-hosted site added, open a GB post (should auto-enable GB), start new post → should be Gutenberg

  • Self-hosted site added, open a GB post (should auto-enable GB), clean app data, re-add self-hosted site, start new post → should be Aztec

  • Self-hosted site added, open a GB post (should auto-enable GB), clean app data, re-add self-hosted site, open a GB post → auto-enables Gutenberg

  • Migrate a selfhosted from v12.9 with GB OFF and been auto-enabled, start new post → should be Aztec in all selfhosted sites

  • Migrate from v12.9 with GB OFF and never auto-enabled, start new post → should be Aztec in all selfhosted sites

  • Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and start new post → should be Aztec

  • Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and open GB post → auto-enables Gutenberg on the site.
    Update release notes:


  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

This allow us to add a footer text to it.
Separating local setter from networking sync makes it simpler to test
…ting

[Gutenberg] Sync editor setting per site
- Users that previously and explicitly disabled gutenberg, will keep using Aztec.
- Default for Self-Hosted will still be Aztec
Now Editor default does not depend on User ID
@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Jul 29, 2019
@etoledom etoledom added this to the 13.0 milestone Jul 29, 2019
@etoledom etoledom self-assigned this Jul 29, 2019
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@koke
Copy link
Member

koke commented Jul 29, 2019

Migrate from v12.9 with GB ON, start new post → should be Gutenberg in all sites

I am getting the popup for new posts after a migration (from 12.8)

@hypest hypest requested a review from koke July 29, 2019 17:32
@diegoreymendez
Copy link
Contributor

@etoledom - Can the branch be deleted?

@etoledom etoledom deleted the feature/gutenberg-sync-opt-in branch August 22, 2019 15:51
@etoledom
Copy link
Contributor Author

Deleted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants