-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Migration to per-site editor setting and sync with server #12221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow us to add a footer text to it.
…-gutenberg-switch-to-site-settings
…-gutenberg-switch-to-site-settings
Separating local setter from networking sync makes it simpler to test
…itch-to-site-settings
…itch-to-site-settings
…ting [Gutenberg] Sync editor setting per site
- Users that previously and explicitly disabled gutenberg, will keep using Aztec. - Default for Self-Hosted will still be Aztec
Now Editor default does not depend on User ID
This same logic is implemented on `Blog.isGutenbergEnabled`
The dialog is show on blogs created from the mobile app the very first time the Gutenberg edior is opened, including when starting a new empty gutenberg post.
…gutenberg from the server
…r-default-migration [Gutenberg] - PR 02 - Editor default and migration
Generated by 🚫 dangerJS |
I am getting the popup for new posts after a migration (from 12.8) |
koke
approved these changes
Jul 29, 2019
1 task
@etoledom - Can the branch be deleted? |
Deleted 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
WP.com/Jetpack sites
Selfhosted sites
Self-hosted site added, start new post → should be Aztec
Self-hosted site added, open a GB post → auto-enables Gutenberg
Self-hosted site added, open a GB post (should auto-enable GB), start new post → should be Gutenberg
Self-hosted site added, open a GB post (should auto-enable GB), clean app data, re-add self-hosted site, start new post → should be Aztec
Self-hosted site added, open a GB post (should auto-enable GB), clean app data, re-add self-hosted site, open a GB post → auto-enables Gutenberg
Migrate a selfhosted from v12.9 with GB OFF and been auto-enabled, start new post → should be Aztec in all selfhosted sites
Migrate from v12.9 with GB OFF and never auto-enabled, start new post → should be Aztec in all selfhosted sites
Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and start new post → should be Aztec
Migrate from v12.9 with GB OFF and never auto-enabled, open a GB post (should auto-enable GB), change to other site and open GB post → auto-enables Gutenberg on the site.
Update release notes:
RELEASE-NOTES.txt
.