Dark mode: NUX improvements #12386
Dark mode: NUX improvements #12386
Conversation
| return UIColor(light: .white, dark: .systemGray5) | ||
| } | ||
| #endif | ||
| return UIColor(light: .white, dark: .neutral(.shade80)) |
There was a problem hiding this comment.
We don't need dark mode colors if this isn't in Xcode 11. You can return .white here. Same principle applies to the next three.
|
Thanks @nheagy! |
|
@nheagy I fixed the issue you mentioned, and I noticed the NUX epilogue also needed some love so I pushed up some fixes there – would you mind checking that too please?
|
All of this looks good! There are some additional updates to be made to the prologue and the button styles but I think we can address them in separate PRs. |
| @@ -146,7 +146,7 @@ private extension LoginEpilogueViewController { | |||
| let panelHeight = buttonPanel.frame.height | |||
|
|
|||
| if contentSize.height > (screenHeight - panelHeight) { | |||
| buttonPanel.backgroundColor = .white | |||
| buttonPanel.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | |||
There was a problem hiding this comment.
This makes me wonder if the epilogue should pull more values from WordPressAuthenticator.shared.style, just to make sure we're consistent. Anyway—that's your call now 😉
Refs #12320. This PR implements some improvements to the appearance of the login flow for dark mode.
Shouldn't be noticeable changes in light mode.
To test:
Update release notes:
RELEASE-NOTES.txtif necessary.cc @mattmiklic