Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn error initializing Core Data into proper exception #12569

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

koke
Copy link
Member

@koke koke commented Sep 27, 2019

This would at least allow us to capture the message and context of the error

For #12338

I'm wondering if we should ship this in a 13.2 hot fix instead, since 13.3 is still a week away (cc @jtreanor)

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This would at least allow us to capture the message and context of the error
@koke koke added this to the 13.3 ❄️ milestone Sep 27, 2019
@koke koke requested a review from aerych September 27, 2019 13:09
Copy link
Member

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. :shipit:

@koke koke merged commit 7427d7d into release/13.3 Sep 27, 2019
@koke koke deleted the issue/12338-exception-for-crash branch September 27, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants