-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new AppID for iOS 14 Home Widget #15123
Add new AppID for iOS 14 Home Widget #15123
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AliSoftware ! To give more context, I would expect that the current App Id will be actually used to release the new "Today Widget" (unless there are other issues that I am not aware of). There will be two more for two other widgets ("All Time" and "This Week") that will use the same naming convention.
For this development we are using a feature branch (one per widget) since we can't use feature flags for widgets; so it will be merged only when the widget development has been completed.
Ok so I guess that:
If you, can I ask you to ping back here in the future once you think the dev is completed to signal that we should be ready to move this forward? Thx 🙂 |
After some back-and-forth today, I ended up creating the profiles. We can either:
or
|
@@ -9,6 +9,17 @@ end | |||
|
|||
USER_ENV_FILE_PATH = File.join(Dir.home, '.wpios-env.default') | |||
PROJECT_ENV_FILE_PATH = File.expand_path(File.join(Dir.pwd, '../../.configure-files/project.env')) | |||
ALL_BUNDLE_IDENTIFIERS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice refactor! 😄
I think it might make more sense to merge this into #15132 after all, That way potential additional changes in that draft PR over there could already add other BundleIDs for the other types of home widgets they plan to add in the future (ThisWeek, AllTimes). I see that the PR doesn't target |
…/update-appid-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @AliSoftware !!
@Gio2018 recently added the "Wordpress Home Widget Today" App ID to our dev portal, so I figured it would be worth adding it in the list for our lanes managing profiles.
🚧 This seems to currently fail though, because there's no InHouse profile with that AppID yet:[EDIT: Profiles have now been created by Jeremy, see below]