Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new AppID for iOS 14 Home Widget #15123

Merged

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Oct 19, 2020

@Gio2018 recently added the "Wordpress Home Widget Today" App ID to our dev portal, so I figured it would be worth adding it in the list for our lanes managing profiles.

🚧 This seems to currently fail though, because there's no InHouse profile with that AppID yet:

No matching provisioning profiles found for 'InHouse_org.wordpress.alpha.WordPressHomeWidgetToday.mobileprovision'
A new one cannot be created because you enabled readonly

[EDIT: Profiles have now been created by Jeremy, see below]

@AliSoftware AliSoftware added the Tooling Build, Release, and Validation Tools label Oct 19, 2020
@AliSoftware AliSoftware added this to the 16.1 milestone Oct 19, 2020
@AliSoftware AliSoftware self-assigned this Oct 19, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 19, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 19, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AliSoftware ! To give more context, I would expect that the current App Id will be actually used to release the new "Today Widget" (unless there are other issues that I am not aware of). There will be two more for two other widgets ("All Time" and "This Week") that will use the same naming convention.
For this development we are using a feature branch (one per widget) since we can't use feature flags for widgets; so it will be merged only when the widget development has been completed.

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Oct 19, 2020

Ok so I guess that:

  • it's probably still too soon to merge that PR anyway until the feature lands
  • we'll need to push new commits to that PR later to add AllTime and ThisWeek widgets once the're ready before moving this PR forward anyway
  • But once this feature lands and development has been completed we can consider circle back to this PR to add it, right?

If you, can I ask you to ping back here in the future once you think the dev is completed to signal that we should be ready to move this forward? Thx 🙂

@jkmassel
Copy link
Contributor

After some back-and-forth today, I ended up creating the profiles. We can either:

or

@@ -9,6 +9,17 @@ end

USER_ENV_FILE_PATH = File.join(Dir.home, '.wpios-env.default')
PROJECT_ENV_FILE_PATH = File.expand_path(File.join(Dir.pwd, '../../.configure-files/project.env'))
ALL_BUNDLE_IDENTIFIERS = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice refactor! 😄

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Oct 21, 2020

I think it might make more sense to merge this into #15132 after all, That way potential additional changes in that draft PR over there could already add other BundleIDs for the other types of home widgets they plan to add in the future (ThisWeek, AllTimes).

I see that the PR doesn't target develop yet but an intermediate branch likely used for incremental work until this is ready for develop, so there's likely gonna be more PRs targetting that feature/ios-14-today-widget branch before said branch ends up in develop anyway

@AliSoftware AliSoftware changed the base branch from develop to feature/15103-today-widget-small-size-ui October 21, 2020 13:08
@AliSoftware AliSoftware marked this pull request as ready for review October 21, 2020 13:15
@AliSoftware
Copy link
Contributor Author

@Gio2018 I changed the target branch of this PR to point to your #15132 draft PR. Feel free to approve and merge when ready and continue your work on your draft PR from there :)

@AliSoftware AliSoftware changed the title [WIP] Add new AppID for iOS 14 Home Widget Add new AppID for iOS 14 Home Widget Oct 21, 2020
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @AliSoftware !!

@Gio2018 Gio2018 merged commit ebf5794 into feature/15103-today-widget-small-size-ui Oct 21, 2020
@Gio2018 Gio2018 deleted the platform/update-appid-list branch October 21, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants